feat: allow self onboarding with public servicedata #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdh
reviewed
Jul 23, 2024
internal/api/v1beta1/user.go
Outdated
| return nil, grpcUnauthenticated | ||
| } | ||
| userSelfOnboard = true | ||
| if !h.checkIsPublicEditable(ctx, metaDataMap) { |
There was a problem hiding this comment.
Instead of calling it public, what about calling it wildcard?
checkIsWildcardEditable
ishanarya0
added a commit
that referenced
this pull request
Aug 21, 2024
* feat: allow edit role on servicedatakey to be public * feat: allow self onboarding with public servicedata (#89) * feat: allow self onboarding with public servicedata * refactor * chore: add go mod file * chore: add formating directive * fix: err * chore: fmt * test: add test to cover self onboarding scenario * update mock * feat: use caller email if user email is missing in payload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An user shall be able to onboard herself (only), provided the servicedata she is trying to add has public EDIT permissions.